Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build with libbsd-overlay #648

Merged
merged 1 commit into from
Oct 8, 2022
Merged

build with libbsd-overlay #648

merged 1 commit into from
Oct 8, 2022

Conversation

neheb
Copy link
Contributor

@neheb neheb commented Aug 12, 2022

Simplifies the code. Upstream also recommends it.

Signed-off-by: Rosen Penev [email protected]

https://gitlab.freedesktop.org/libbsd/libbsd/-/issues/11#note_1417771

Simplifies the code. Upstream also recommends it.

Signed-off-by: Rosen Penev <[email protected]>
@nmoinvaz
Copy link
Member

nmoinvaz commented Oct 8, 2022

Is libbsd-overlay available in all the same platforms? Do we need a fallback if libbsd-overlay does not exist?

@nmoinvaz
Copy link
Member

nmoinvaz commented Oct 8, 2022

On Ubuntu 18 only libbsd-dev found in package search..

@neheb
Copy link
Contributor Author

neheb commented Oct 8, 2022

libbsd-dev includes overlay. It's also supported on Windows.

@nmoinvaz nmoinvaz merged commit cf26418 into zlib-ng:master Oct 8, 2022
@neheb neheb deleted the ov branch October 8, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants