Fix private linking of LibLZMA #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current `liblzma` makes linke look for `libliblzma` as the `lib` prefix is added automatically. This is breaking static linking of library when using pkg-config for resolving dependencies.
|
I've also now noticed, that now in the pc file, between version 3.0.7 and 3.0.8, ssl started to be linked using absolute paths instead of -lssl and -lcrypto: 3.0.7: 3.0.8 and as you see the pthread is linked incorrectly... |
nmoinvaz
approved these changes
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
liblzmamakes linke look forlibliblzmaas thelibprefix is added automatically. This is breaking static linking of library when using pkg-config for resolving dependencies.