Fix MZ_FETCH_LIBS option for non-WIN32 systems #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `cmake_dependent_option` overrides a previously set directory scope MZ_FETCH_LIBS variable. This means if a project sets MZ_FETCH_LIBS before adding minizip-ng as a subdirectory in order to force it to fetch zlib, it will set the variable to OFF, only use `find_library` and never fetch zlib on non-WIN32 systems. This is a regression from previous behaviour. Instead, revert back to using `option` as this obeys a directory scope MZ_FETCH_LIBS variable set by a parent directory, allowing said parent directory to control zlib version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
cmake_dependent_optionoverrides a previously set directory scope MZ_FETCH_LIBS variable. This means if a project sets MZ_FETCH_LIBS before adding minizip-ng as a subdirectory in order to force it to fetch zlib, it will set the variable to OFF, only usefind_libraryand never fetch zlib on non-WIN32 systems. This is a regression from previous behaviour.Instead, revert back to using
optionas this obeys a directory scope MZ_FETCH_LIBS variable set by a parent directory, allowing said parent directory to control zlib version.