workaround IE bug

zloirock · Jun 11, 2023 · 38592f4 · 38592f4
1 parent 867540b
commit 38592f4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/core-js/internals/array-group.js b/packages/core-js/internals/array-group.js
@@ -21,7 +21,7 @@ module.exports = function ($this, callbackfn, that, specificConstructor) {
   for (;length > index; index++) {
     value = self[index];
     key = toPropertyKey(boundFunction(value, index, O));
-    // in some IE10 builds, `hasOwnProperty` returns incorrect result on integer keys
+    // in some IE versions, `hasOwnProperty` returns incorrect result on integer keys
     // but since it's a `null` prototype object, we can safely use `in`
     if (key in target) push(target[key], value);
     else target[key] = [value];

diff --git a/packages/core-js/modules/esnext.object.group-by.js b/packages/core-js/modules/esnext.object.group-by.js
@@ -4,7 +4,6 @@ var getBuiltIn = require('../internals/get-built-in');
 var uncurryThis = require('../internals/function-uncurry-this');
 var aCallable = require('../internals/a-callable');
 var requireObjectCoercible = require('../internals/require-object-coercible');
-var has = require('../internals/has-own-property');
 var toPropertyKey = require('../internals/to-property-key');
 var iterate = require('../internals/iterate');
 
@@ -21,8 +20,10 @@ $({ target: 'Object', stat: true, forced: true }, {
     var k = 0;
     iterate(items, function (value) {
       var key = toPropertyKey(callbackfn(value, k++));
-      if (!has(obj, key)) obj[key] = [value];
-      else push(obj[key], value);
+      // in some IE versions, `hasOwnProperty` returns incorrect result on integer keys
+      // but since it's a `null` prototype object, we can safely use `in`
+      if (key in obj) push(obj[key], value);
+      else obj[key] = [value];
     });
     return obj;
   }