Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NodeList.prototype.forEach() #329

Closed
yuheiy opened this issue Aug 20, 2017 · 10 comments
Closed

Implement NodeList.prototype.forEach() #329

yuheiy opened this issue Aug 20, 2017 · 10 comments

Comments

@yuheiy
Copy link

yuheiy commented Aug 20, 2017

should you implement this?

https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach

@christiansany
Copy link

I'd volunteer for the implementation of this polyfill :)

@Jarlotee
Copy link

@christiansany DO IT!

@zloirock
Copy link
Owner

Added to v3 branch.

@zloirock zloirock mentioned this issue Dec 1, 2017
@zloirock zloirock closed this as completed Dec 8, 2017
SthephanShinkufag referenced this issue in SthephanShinkufag/Dollchan-Extension-Tools Feb 24, 2018
@RusinovAnton
Copy link

Hey whats the current status of this? Do you need any help?

@AlexWayfer
Copy link
Contributor

Hey whats the current status of this?

It's checked in v3 PR.

c908a46

@firestar300
Copy link

firestar300 commented Aug 3, 2018

Hello,

It doesn't work.

I use Webpack.

  entry: {
    app: ['@babel/polyfill', './src/css/style.scss', './src/js/app.js'],
  },

input :

document.querySelectorAll('.test').forEach(el => {
  console.log(el)
})

output :

document.querySelectorAll('.test').forEach(function (el) {
  console.log(el);
});

So I have this expected error on IE11 : Object doesn't support property or method 'forEach'

I expected something like that :

[].call.forEach(document.querySelectorAll('.test'), function (el) {
  console.log(el);
});

Did I miss something ?

@AlexWayfer
Copy link
Contributor

Did I miss something ?

@babel/polyfill locked at core-js 2, and there is no core-js 3 stable release.

So…

@zloirock, what about v3 release? PR was merged, three betas were released, and no new beta since early June.

@firestar300
Copy link

@babel/polyfill locked at core-js 2, and there is no core-js 3 stable release.

Oh yes.. I didn't notice that. Thanks for the answer.

@SebiTimeWaster
Copy link

no new releases since june?

@theianjohnson
Copy link

Running into this same issue and would love to see a forEach polyfill get merged in 👍

moorejs added a commit to moorejs/core-js that referenced this issue Sep 21, 2021
…ction prototypes

These appear to be added to address zloirock#329. However, only NodeList and
DOMTokenList are documented and tested to have these functions on their
prototypes.
moorejs added a commit to moorejs/core-js that referenced this issue Sep 21, 2021
…ction prototypes

These appear to be added to address zloirock#329. However, only NodeList and
DOMTokenList are documented and tested to have these functions on their
prototypes.
moorejs added a commit to moorejs/core-js that referenced this issue Sep 21, 2021
These appear to be added to address zloirock#329. However, only NodeList and
DOMTokenList are documented and tested to have forEach on their
prototypes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants