limit postinstall ad to show only one time #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing multiple packages that depend on core-js, the postinstall message will pop up mutiple times which will add unnecessary verbosity to the terminal log. I know zloirock#767, zloirock#548, zloirock#797, zloirock#757, zloirock#781 ,zloirock#729, zloirock#708, refer to this problem and since @zloirock refuses to remove this, lets limit it to one time so that verbosity gets truncated to the least.
JakeChampion
approved these changes
Apr 12, 2020
|
@obnoxiousnerd great work |
|
My pleasure, @sgammon . |
|
@obnoxiousnerd I see this PR. I am ready to accept it. |
|
All right, @slowcheetah |
|
Just doooo it |
|
Repeat ad protection already exists. If the problem arises, then most likely the old version of core-js is installed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing multiple packages that depend on core-js, the postinstall message will pop up mutiple times which will add unnecessary verbosity to the terminal log. I know #767, #548, #797, #757, #781 ,#729, #708, refer to this problem and since @zloirock refuses to remove this, lets limit it to one time so that verbosity gets truncated to the least.