Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit underscores in DNSNames if-and-only-if replacing all underscores results in valid LDH labels during BR 1.6.2's permissibility period #661

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

christopher-henderson
Copy link
Member

@christopher-henderson christopher-henderson commented Feb 6, 2022

This lint encodes a brief period from December 10th 2018 to April 1st 2019 wherein CABF BR permitted underscores within DNS names if-and-only replacing each underscore with a hyphen would result in a valid LDH label.

@christopher-henderson christopher-henderson changed the title DO NOT REVIEW underscores in dns permissible if LDH valid after replacement BR lint to permit underscores in DNSNames if-and-only-if replacing all underscores results in valid LDH labels during BR 1.6.2's permissibility period Feb 6, 2022
@christopher-henderson christopher-henderson changed the title BR lint to permit underscores in DNSNames if-and-only-if replacing all underscores results in valid LDH labels during BR 1.6.2's permissibility period Permit underscores in DNSNames if-and-only-if replacing all underscores results in valid LDH labels during BR 1.6.2's permissibility period Feb 6, 2022
Copy link
Contributor

@sleevi sleevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With all the other changes folded in, LGTM. A nit below.

v3/util/fqdn.go Outdated Show resolved Hide resolved
@christopher-henderson
Copy link
Member Author

@sleevi gentle re-engagement on this

@dadrian dadrian merged commit 48baa89 into master Sep 27, 2023
8 checks passed
@dadrian dadrian deleted the underscore_br_3 branch September 27, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants