Add lint for BR 7.1.4.2.2a mailbox-validated #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopher-henderson
requested changes
Mar 9, 2024
There was a problem hiding this comment.
So the table of acceptable values is as follows...
| Certificate Type | Contents |
|---|---|
| Mailbox-validated | Mailbox Address |
| Organization-validated | subject:organizationName or Mailbox Address |
| Sponsor-validated | Personal Name, subject:pseudonym, or Mailbox Address |
| Individual-validated | Personal Name, subject:pseudonym, or Mailbox Address |
This lint, as written, appears to only be checking the first row (mailbox validated).
This is perfectly fine, although I suppose that we should state this explicitly in the citation.
Do you think that the following reasonable?
If present, the commonName attribute of a mailbox validated certificate SHALL contain a mailbox address
|
Thanks for the review. Yes, I intended to check only the mailbox-validated certificates with this PR (as indicated by the title and lint filename). I updated the description. |
christopher-henderson
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to san.go are copied from #800.