Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Minor fixes for server compatibility #65

Merged
merged 1 commit into from
Apr 26, 2019
Merged

[chore] Minor fixes for server compatibility #65

merged 1 commit into from
Apr 26, 2019

Conversation

zmbush
Copy link
Owner

@zmbush zmbush commented Apr 26, 2019

Also, fix the uniqueness constraint on notes

Also, fix the uniqueness constraint on notes
@todo
Copy link

todo bot commented Apr 26, 2019

Server needs Postgres 9.5 to support ON CONFLICT DO NOTHING

In the meantime, we will just ignore the result from the following execute.


noted/db/src/models.rs

Lines 254 to 259 in 0787ff0

// TODO: Server needs Postgres 9.5 to support ON CONFLICT DO NOTHING
// BODY: In the meantime, we will just ignore the result from the following execute.
let _ = diesel::insert_into(tags)
.values(&set_tags.iter().map(|t| tag.eq(t)).collect::<Vec<_>>())
// .on_conflict_do_nothing()
.execute(db);


This comment was generated by todo based on a TODO comment in 0787ff0 in #65. cc @zmbush.

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #65 into master will increase coverage by 3.17%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   41.37%   44.55%   +3.17%     
==========================================
  Files          23       23              
  Lines         899      918      +19     
  Branches       22       22              
==========================================
+ Hits          372      409      +37     
+ Misses        527      509      -18
Impacted Files Coverage Δ
db/src/models.rs 87.91% <95.23%> (+12.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 663c016...0787ff0. Read the comment docs.

@zmbush zmbush merged commit 3e29098 into master Apr 26, 2019
@zmbush zmbush deleted the subnotes branch April 26, 2019 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant