feat: Added a flag to key press behavior to allow it to be inverted #2554
+103
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if two of the same binding are pressed and then released, the first release will be treated as both keys being released.
This adds a new optional flag to the key press behavior
invert-if-active
causing the behavior to invert its function if the binding is already pressed:This flag resolves this inconsistent behavior, but is marked as optional for backwards compatibility and as it is less intuitive.
It is also a quite useful interaction, in my opinion:
EDIT: I have a feeling that this may interact poorly with combos. This is a note telling me to test that interaction in the future when I get around to it.