behaviors(hold-tap): Implement quick_tap_ms (TAPPING_FORCE_HOLD) #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okke-formsma
force-pushed
the
tapping-force-hold
branch
from
25bfeca
to
a3a2d60
Compare
okke-formsma
force-pushed
the
tapping-force-hold
branch
from
a3a2d60
to
626991c
Compare
okke-formsma
requested review from
petejohanson,
innovaker and
joelspadin
and removed request for
petejohanson
petejohanson
approved these changes
Feb 2, 2021
There was a problem hiding this comment.
This is awesome!
Working like a champ for my layer taps on my Ferris, and tested by a few users, includes great tests as usual.
Thanks @okke-formsma
|
@okke-formsma Argh! The refactor for the transform stuff caused conflicts. Can you please rebase, then we'll merge? Thanks! |
Tap-and-hold a hold-tap to hold the tap behavior so it can repeat. After a tap, if the same key is pressed within `quick_tap_ms`, the tap behavior is always picked. This is useful for things like `&ht LSHFT BACKSPACE` where holding the backspace is required. Implements zmkfirmware#288.
okke-formsma
force-pushed
the
tapping-force-hold
branch
from
626991c
to
34faa63
Compare
petejohanson
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tap-and-hold a hold-tap to hold the tap behavior so it can repeat.
After a tap, if the same key is pressed within
quick_tap_ms, thetap behavior is always picked.
This is useful for things like
&ht LSHFT BACKSPACEwhere holdingthe backspace is required.
Implements #288