Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain gcm version to 16.1.0 #1092

Closed
wants to merge 2 commits into from
Closed

Constrain gcm version to 16.1.0 #1092

wants to merge 2 commits into from

Conversation

melissamcdougall
Copy link

With the latest firebase/gcm release (https://developers.google.com/android/guides/releases), the latest version (+) now brings in androidx dependencies. react-native won't be ready for androidx until 0.60 so constraint the gcm version to 16.1.0 (the latest pre-androidx version)

Thanks to @benoitdion for this exact fix on react-native-device-info (react-native-device-info/react-native-device-info#693)

@melissamcdougall
Copy link
Author

Added firebase version too, based on feedback from #1091

@leonidez
Copy link

I added this change manually in Android studio and can confirm it's working.

@bgerhards
Copy link

bgerhards commented Jun 18, 2019

For anyone else waiting for this fix, you can add the following to your gradle.properties.

googlePlayServicesVersion=16.1.0
firebaseVersion=17.6.0

@pavermakov
Copy link

Any plans on merging this anytime soon?

@melissamcdougall
Copy link
Author

Doesn't look like @zo0r has been merging/working on this project much (or at all) this year, so I expect it might be a while, if at all.

@kristoferpelchat
Copy link

@zo0r @mattimck I have forked and tested and all works well for me...thanks for the fix @mattimck !!!!!! I will monitor this to see when/if it ever makes it tomaster! 👍

@HarshitMadhav
Copy link

HarshitMadhav commented Jun 19, 2019

@bgerhards It did work for me but with this at the end of build.gradle (Module : app) file

configurations.all {
    resolutionStrategy {
        force 'com.google.android.gms:play-services-gcm:16.1.0'
        force 'com.google.android.gms:play-services-base:16.1.0'
        force 'com.google.firebase:firebase-core:16.0.6'
        force 'com.google.firebase:firebase-messaging:17.6.0'
    }}

and also using this in build.gradle

ext{     
     googlePlayServicesVersion = "16.1.0"
     firebaseVersion = "17.6.0"
}

also change the compilesdkversion to 28

@erhanbicer
Copy link

@HarshitMadhav thanks. it worked for me.

@ch-tactica
Copy link

Anybody having issues with permissions not being requested anymore?

@HarshitMadhav
Copy link

@ch-tactica what do you mean?

@Peretz30
Copy link

This fix helped to create a build, but PushNotification.localNotification doesn't work at all. Nothing happens.

@ch-tactica
Copy link

I'm having the same issues as @Peretz30, PushNotification.localNotication isn't working. I suspect it has something to do with the fact that I'm no longer getting a prompt for permissions.

@HarshitMadhav
Copy link

@Peretz30 and @ch-tactica for me pushnotification.localNotification is working maybe you are missing some metadata or some channel issues might be there. Check your channel and AndroidManifest.xml.

@Peretz30
Copy link

Peretz30 commented Jul 2, 2019

@HarshitMadhav you are right, I missed Chanel info in AndroidManifest, thanks to #946 (comment)
@ch-tactica did you have this lines in AndroidManifest?

@HarshitMadhav
Copy link

@Peretz30 Glad, I could help. Cheers!

@HarshitMadhav
Copy link

@ch-tactica Please follow the link that @Peretz30 has posted! You are missing the channel info in AndroidManifest.xml

Copy link

@tobiasgemperli tobiasgemperli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.