-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constrain gcm version to 16.1.0 #1092
Conversation
Added firebase version too, based on feedback from #1091 |
I added this change manually in Android studio and can confirm it's working. |
For anyone else waiting for this fix, you can add the following to your
|
Any plans on merging this anytime soon? |
Doesn't look like @zo0r has been merging/working on this project much (or at all) this year, so I expect it might be a while, if at all. |
@zo0r @mattimck I have forked and tested and all works well for me...thanks for the fix @mattimck !!!!!! I will monitor this to see when/if it ever makes it to |
@bgerhards It did work for me but with this at the end of build.gradle (Module : app) file
and also using this in build.gradle
also change the compilesdkversion to 28 |
@HarshitMadhav thanks. it worked for me. |
Anybody having issues with permissions not being requested anymore? |
@ch-tactica what do you mean? |
This fix helped to create a build, but PushNotification.localNotification doesn't work at all. Nothing happens. |
I'm having the same issues as @Peretz30, |
@Peretz30 and @ch-tactica for me pushnotification.localNotification is working maybe you are missing some metadata or some channel issues might be there. Check your channel and AndroidManifest.xml. |
@HarshitMadhav you are right, I missed Chanel info in |
@Peretz30 Glad, I could help. Cheers! |
@ch-tactica Please follow the link that @Peretz30 has posted! You are missing the channel info in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
With the latest firebase/gcm release (https://developers.google.com/android/guides/releases), the latest version (+) now brings in androidx dependencies. react-native won't be ready for androidx until 0.60 so constraint the gcm version to 16.1.0 (the latest pre-androidx version)
Thanks to @benoitdion for this exact fix on
react-native-device-info
(react-native-device-info/react-native-device-info#693)