Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firebase (FCM) support #717

Merged
merged 3 commits into from
Jul 17, 2018
Merged

Add Firebase (FCM) support #717

merged 3 commits into from
Jul 17, 2018

Conversation

avencat
Copy link

@avencat avencat commented Apr 17, 2018

This PR adds Firebase support to this repository. I'm not an Android developer so please feel free to let me know if there's some weirdness on the code. I made this PR as GCM is being outdated and need to be replaced by FCM. In order to do this PR, I followed the steps provided by @Rah1x in #697. Hope this will help!

@calcazar
Copy link

calcazar commented Apr 25, 2018

I'm supporting a clone of this library located here: https://github.com/calcazar/react-native-push-notification-CE and added your changes to it :)

@iamarkdev
Copy link

@zo0r - Can we get this reviewed?

@baselbj
Copy link

baselbj commented May 21, 2018

so is it now supporting firebase?

@alexsegura
Copy link

alexsegura commented Jun 7, 2018

Also see #710 for changes in AndroidManifest.xml

EDIT: Oh ok I didn't see that you documented it 👍

@lucidtheory
Copy link

lucidtheory commented Jul 4, 2018

Been a few months and no word. Does this need to be forked to use these changes?

may just use the fork @calcazar built. Thanks

@alexsegura
Copy link

Personally, I switched to using react-native-firebase for Android 😐

@Gp2mv3
Copy link
Contributor

Gp2mv3 commented Jul 4, 2018

@zo0r has no more time to manage this repo. He gave me the access. What's the state of this PR ? Is it ready to be merged according to you ? Do you have a working example of it ?

@Gp2mv3 Gp2mv3 added the question label Jul 4, 2018
@Gp2mv3 Gp2mv3 mentioned this pull request Jul 4, 2018
@avencat
Copy link
Author

avencat commented Jul 4, 2018

Hi @Gp2mv3 yes I think it’s ready, I’ll give it a check tomorrow, you can check this fork that already uses it: https://github.com/calcazar/react-native-push-notification-CE

@avencat
Copy link
Author

avencat commented Jul 6, 2018

@Gp2mv3 that's ok, I checked! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants