Fix enum pattern matching #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GerardSmit
commented
Aug 6, 2024
| return typeSymbol switch | ||
| { | ||
| null => typeSyntax, | ||
| { TypeKind: TypeKind.Enum } when typeSyntax is QualifiedNameSyntax { Right: IdentifierNameSyntax r } && (r.Identifier.ValueText != typeSymbol.Name || typeSymbol.ToString() != typeSyntax.WithoutTrivia().ToString()) |
There was a problem hiding this comment.
I've added a quick check with r.Identifier.ValueText != typeSymbol.Name which is almost always true, because typeSymbol.ToString() is allocating a string. The edge case is if the enum value and enum have the same name, e.g.
enum Test { Test }This would fail with r.Identifier.ValueText != typeSymbol.Name. I've added a unit test for this.
virzak
reviewed
Aug 7, 2024
| @@ -0,0 +1,2 @@ | |||
| //HintName: Test.Class.MethodAsync.g.cs | |||
| _ = System.Data.ConnectionState.Closed is global::System.Data.ConnectionState.Closed; | |||
There was a problem hiding this comment.
I think it should be:
_ = global::System.Data.ConnectionState.Closed is global::System.Data.ConnectionState.Closed;
virzak
approved these changes
Aug 7, 2024
|
Thanks a lot for the PR. I expanded your test case to cover using static class. The change is in the latest nuget package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
ispattern matching with enums, the enum value is dropped. For example:Gets converted to:
This PR checks if the type is an enum and doesn't match the base
typeSyntax(because the right-side is missing) and then adds it back.