Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react-router Link from /about and /get-involved #7172

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

goplayoutside3
Copy link
Contributor

@goplayoutside3 goplayoutside3 commented Sep 11, 2024

Staging branch URL: https://pr-7172.pfe-preview.zooniverse.org

Removes react-router Link from /about and /get-involved in router.jsx.

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

@coveralls
Copy link

Coverage Status

coverage: 56.816%. remained the same
when pulling 7059584 on fix-site-nav-links
into 5bf177a on master.

@goplayoutside3
Copy link
Contributor Author

Merging without review, see more details here: https://zooniverse.slack.com/archives/C010QAPB67J/p1726074820858029

@goplayoutside3 goplayoutside3 merged commit f5ac7ef into master Sep 11, 2024
5 checks passed
@goplayoutside3 goplayoutside3 deleted the fix-site-nav-links branch September 11, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants