Add json-api-client to this repo #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eatyourgreens
force-pushed
the
json-api-client
branch
from
4bf4d65
to
51476f2
Compare
|
If we merge this, we can deprecate https://github.com/zooniverse/json-api-client. zooniverse/Panoptes-Front-End#6369 is a feature branch that's set up to test this version of the client. |
eatyourgreens
force-pushed
the
json-api-client
branch
from
fc5523a
to
e2ad22e
Compare
|
The JSON-API client code here is from v7.0.2. |
eatyourgreens
force-pushed
the
json-api-client
branch
from
e2ad22e
to
710567e
Compare
mcbouslog
reviewed
Jan 24, 2023
mcbouslog
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
Tested this at https://pr-6369.pfe-preview.zooniverse.org/ throughly. Signed in/out, made classifications, posted/edited to Talk, created a project, edited a project/workflow/task. I think this is working well, but let me know if there are any user actions I've neglected to test.
So I think this is good to go! 👍
Move the `json-api-client` code into `lib/json-api-client` and require it from there. Remove `json-api-client` as a dependency.
eatyourgreens
force-pushed
the
json-api-client
branch
from
710567e
to
66e70a4
Compare
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
json-api-clientcode intolib/json-api-clientand require it from there. Removejson-api-clientas a dependency.