Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SugarClient tests #192

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Add SugarClient tests #192

merged 1 commit into from
Jan 27, 2023

Conversation

eatyourgreens
Copy link
Contributor

  • move the old tests to /tape-test.
  • add the SugarClient tests from zooniverse/Sugar-Client.
  • install mocha, chai and chai-spies.

Run the Mocha tests with npx mocha.

Run all the tests with npm test.

@eatyourgreens
Add SugarClient tests
81b230c 
- move the old tests to `/tape-test`.
- add the SugarClient tests from `zooniverse/Sugar-Client`.
- install `mocha`, `chai` and `chai-spies`.
mcbouslog
mcbouslog approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@mcbouslog mcbouslog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests look good, run (and pass) as expected 👍

@eatyourgreens eatyourgreens merged commit af1c3a0 into master Jan 27, 2023
@eatyourgreens eatyourgreens deleted the sugar-tests branch January 27, 2023 18:08
@eatyourgreens eatyourgreens mentioned this pull request Jan 28, 2023
Merged
@eatyourgreens eatyourgreens mentioned this pull request Mar 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcbouslog mcbouslog mcbouslog approved these changes

Assignees

@mcbouslog mcbouslog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eatyourgreens @mcbouslog