SugarClient: Bump Primus to 8.0.9 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunanoordin
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
PR Review
This PR syncs the PJC to the latest version of Primus, which means the removal of the "Esc button hack" is now official. Woo!
- We had earlier removed the hack in_our copy_ of Primus (#223)...
- ...and that change is now matched by the Primus source (Remove hacks for outdated browsers primus/primus#783)
For the original context, please see zooniverse/Panoptes-Front-End#6914
LGTM! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This permanently removes the two browser hacks that were temporarily removed from Primus in #223.