-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we require CFFI for PURE_PYTHON usage on CPython? #77
Comments
Also, with #45, I don’t want to have to implement it three times. |
+1. If it blows up in some unexpected way we can revert. :) |
CFFI is not available for Jython, so this would eliminate support for that platform. We don't actually test Jython or list it in the classifiers, but there are some allowances for it in the code (which I would remove as part of this work). Knowing that, is it still a +1? |
+1 from me. |
jamadden
added a commit
that referenced
this issue
Nov 19, 2018
jamadden
added a commit
that referenced
this issue
Nov 20, 2018
jamadden
added a commit
that referenced
this issue
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CFFI distributes binary wheels, so it's a lightweight dependency.
This would simplify our code by letting us remove one of the two implementations of picklecache.Ring, and it would simplify our test matrix and help us reach 100% coverage.
The text was updated successfully, but these errors were encountered: