Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Romanian translations. #123

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

jladage
Copy link
Contributor

@jladage jladage commented Aug 12, 2024

Just added translations for Romanian language.

@icemac
Copy link
Member

icemac commented Aug 13, 2024

Thank you for your contribution.

According to the contributing policies of the zopefoundation organization you need to sign a contributor agreement before any non-trivial change can be merged. For details please consult the Contributing guidelines for zopefoundation projects.

@icemac
Copy link
Member

icemac commented Aug 13, 2024

@MrTango Is your Romanian good enough to review these translations?

@jladage
Copy link
Contributor Author

jladage commented Aug 13, 2024 via email

@icemac
Copy link
Member

icemac commented Aug 14, 2024

@jladage When you sign a Zope contributor agreement, you will get a Member of the zopefoundation project, this is the way I see that the agreement was signed and it will allow you to merge yout PR after successful review.

So I cannot answer your question. I'd suggest either to ask someone of the Plone Foundation or just sign a contributor agreement for Zope.

@icemac
Copy link
Member

icemac commented Oct 2, 2024

@jladage You are now listed as Member are you also able to merge yourself?

@jladage
Copy link
Contributor Author

jladage commented Oct 3, 2024

@icemac nope, at least not if nobody is able to review the Romanian translations I created with deepl.

@davisagli
Copy link
Member

@avoinea Would you like to help review this or ask someone else to?

src/z3c/form/locales/ro/LC_MESSAGES/z3c.form.po Outdated Show resolved Hide resolved
src/z3c/form/locales/ro/LC_MESSAGES/z3c.form.po Outdated Show resolved Hide resolved
src/z3c/form/locales/ro/LC_MESSAGES/z3c.form.po Outdated Show resolved Hide resolved
src/z3c/form/locales/ro/LC_MESSAGES/z3c.form.po Outdated Show resolved Hide resolved
src/z3c/form/locales/ro/LC_MESSAGES/z3c.form.po Outdated Show resolved Hide resolved
src/z3c/form/locales/ro/LC_MESSAGES/z3c.form.po Outdated Show resolved Hide resolved
src/z3c/form/locales/ro/LC_MESSAGES/z3c.form.po Outdated Show resolved Hide resolved
src/z3c/form/locales/ro/LC_MESSAGES/z3c.form.po Outdated Show resolved Hide resolved
src/z3c/form/locales/ro/LC_MESSAGES/z3c.form.po Outdated Show resolved Hide resolved
src/z3c/form/locales/ro/LC_MESSAGES/z3c.form.po Outdated Show resolved Hide resolved
jladage and others added 3 commits October 21, 2024 10:13
Translation fixes

Co-authored-by: Alin Voinea <[email protected]>
Translation fixes

Co-authored-by: Alin Voinea <[email protected]>
Translation fixes ro

Co-authored-by: Alin Voinea <[email protected]>
@jladage
Copy link
Contributor Author

jladage commented Oct 21, 2024

Hi @avoinea, I merged your translation suggestions. Could you please review once more so I can merge?

@jladage jladage self-assigned this Oct 21, 2024
@jladage
Copy link
Contributor Author

jladage commented Oct 21, 2024

@icemac the test coverage is currently blocking this request from merging. I'm not familiar enough with the code to understand why. Do we test translations? Are our changes the result of the test coverage problem?

@icemac
Copy link
Member

icemac commented Oct 22, 2024

@jladage The translations are not part of the coverage and are not tested. I saw a drop in coverage on serveral packages, probably because of a new version of the coverage package.

I'll merge this PR now and tackle the coverage problem later on.

@icemac icemac merged commit 3180556 into zopefoundation:master Oct 22, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants