Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes for WeasyPrint #3

Merged
merged 3 commits into from
Feb 13, 2020
Merged

Minor fixes for WeasyPrint #3

merged 3 commits into from
Feb 13, 2020

Conversation

liZe
Copy link
Contributor

@liZe liZe commented Feb 6, 2020 •
edited
Loading

This pull request has 3 commits that you can cherry-pick or merge, as you want.

  • Force UTF-8 encoding for WeasyPrint, as some tests (at least lesson-hyphenation-long-words) have no explicit charset.
  • Add standard CSS properties where proprietary or nonstandard properties are used.
  • Fix page size for one test where page text differs from real page format.

Related to Kozea/WeasyPrint#1026.

@liZe
Force UTF-8 encoding for WeasyPrint
558a5af 
WeasyPrint (and in particular html5lib) uses Windows-1252 as default encoding,
but tests rely on UTF-8 documents. It works well for HTML documents with
encoding metadata, but fails when metadata is missing.
@liZe
Use standard CSS properties when possible
3d98381
@liZe
Fix page size
a73df68 
CSS page size differs from what the content advertises.
@zopyx
Copy link
Owner

zopyx commented Feb 13, 2020

Will check after XMLPrague

@zopyx zopyx merged commit 238ab2e into zopyx:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liZe @zopyx