Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate live syntax checker in ACE for code window #70

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Activate live syntax checker in ACE for code window #70

merged 1 commit into from
Feb 23, 2018

Conversation

zuphilip
Copy link
Collaborator

@zuphilip zuphilip commented Feb 3, 2018 •
edited
Loading

For example:
scaffold-syntax-checking

@zuphilip zuphilip mentioned this pull request Feb 4, 2018
Open
@dstillman
Copy link
Member

Can you provide a source URL for worker-javascript.js in the commit? We need to document the source of third-party files, particularly large ones.

@zuphilip
Copy link
Collaborator Author

Squashed and reword the commit. Okay now?

@adam3smith
Copy link
Collaborator

I don't have time to review the code, but I did "field-test" this & was very happy with it, so gtg from my end.

@dstillman dstillman merged commit edfe72d into zotero:master Feb 23, 2018
@zuphilip zuphilip deleted the syntax-checker branch February 23, 2018 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zuphilip @dstillman @adam3smith