-
Notifications
You must be signed in to change notification settings - Fork 757
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Lulu: Fix
unreachable code after return statement
warnings
And fix inconsistent return
- Loading branch information
Showing
1 changed file
with
3 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a90a241
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, I'm confused about what we want here.
detectSearch
was disabled in ecb80fa. Now we have a comment sayingdetectSearch
is disabled, one line above a disabling return statement that is itself now disabled. We're making a request to Lulu for each ISBN that other search translators can't resolve, but the translator is still broken.Should we just make this a web translator only? Or try to fix it?
a90a241
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, that was supposed to be a
true
! Thanks for catching that.I've fixed, but yeah, we could just remove the search stuff altogether.