Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Code snippet configuration #2509

Merged
merged 23 commits into from
Jul 22, 2022

Conversation

CarsonCook
Copy link
Contributor

@CarsonCook CarsonCook commented Jul 20, 2022

Description

Adds the apiInfo.codeSnippets configuration to Eureka metadata. Additionally adds refactor for the APIService model to simplify access to the ApiInfo model.

This finishes the server side work for #2385.

Linked to #2385
Part of the #2208

Type of change

Please delete options that are not relevant.

  • (feat) New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations

For more details about how should the code look like read the Contributing guideline

@CarsonCook CarsonCook force-pushed the apiml/GH2385/customized-code-snippets branch from be66f07 to cd47754 Compare July 20, 2022 13:10
@CarsonCook CarsonCook requested a review from taban03 July 22, 2022 12:40
@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.6% 96.6% Coverage
0.0% 0.0% Duplication

@CarsonCook CarsonCook merged commit 4d2298e into v2.x.x Jul 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the apiml/GH2385/customized-code-snippets branch July 22, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants