-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: passticket generation and limit eureka replication peers threads #2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiri Aichler <[email protected]>
Signed-off-by: Jiri Aichler <[email protected]>
Signed-off-by: Jiri Aichler <[email protected]>
Signed-off-by: Jiri Aichler <[email protected]>
Signed-off-by: Jiri Aichler <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
JirkaAichler
changed the title
feat: Limit eureka peers
feat: Limit eureka replication peers threads and fix passticket generation
Mar 20, 2023
JirkaAichler
changed the title
feat: Limit eureka replication peers threads and fix passticket generation
fix: Limit eureka replication peers threads and fix passticket generation
Mar 20, 2023
JirkaAichler
changed the title
fix: Limit eureka replication peers threads and fix passticket generation
fix: passticket generation and limit eureka replication peers threads
Mar 20, 2023
achmelo
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Limit the number of Eureka peer replication threads and make passticket service thread-safe. Gateway could abend with a segmentation error.
Performance test results are difficult to interpret because of the load in the testing environment.
It seems that passticket generation is faster for the load up to 200 concurrent users and slower for the higher load.
Other authentication methods seem to be somehow similar.
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline