Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: passticket generation and limit eureka replication peers threads #2845

Merged
merged 10 commits into from
Mar 20, 2023

Conversation

JirkaAichler
Copy link
Contributor

@JirkaAichler JirkaAichler commented Mar 17, 2023

Description

Limit the number of Eureka peer replication threads and make passticket service thread-safe. Gateway could abend with a segmentation error.

Performance test results are difficult to interpret because of the load in the testing environment.

It seems that passticket generation is faster for the load up to 200 concurrent users and slower for the higher load.
Other authentication methods seem to be somehow similar.

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)
  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation
  • (refactor) Refactor the code
  • (chore) Chore, repository cleanup, updates the dependencies.
  • (BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@sonarcloud
Copy link

sonarcloud bot commented Mar 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.2% 96.2% Coverage
0.0% 0.0% Duplication

@JirkaAichler JirkaAichler changed the title feat: Limit eureka peers feat: Limit eureka replication peers threads and fix passticket generation Mar 20, 2023
@JirkaAichler JirkaAichler changed the title feat: Limit eureka replication peers threads and fix passticket generation fix: Limit eureka replication peers threads and fix passticket generation Mar 20, 2023
@JirkaAichler JirkaAichler changed the title fix: Limit eureka replication peers threads and fix passticket generation fix: passticket generation and limit eureka replication peers threads Mar 20, 2023
@JirkaAichler JirkaAichler marked this pull request as ready for review March 20, 2023 15:26
Copy link
Member

@achmelo achmelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@JirkaAichler JirkaAichler merged commit 42b491e into v2.x.x Mar 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the limit-eureka-peers branch March 20, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants