Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix parsing swagger2 by API Catalog #2876

Merged
merged 5 commits into from
Apr 20, 2023
Merged

Conversation

pj892031
Copy link
Contributor

Description

This PR fixes support of Swagger2 format by API catalog. The bug disallows to show any information about the service using the format. The PR itself upgrades also versions of Swagger libraries to use matching versions.

Linked to #2821
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)
  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation
  • (refactor) Refactor the code
  • (chore) Chore, repository cleanup, updates the dependencies.
  • (BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how the code should look like read the Contributing guideline

@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pj892031 pj892031 marked this pull request as ready for review April 20, 2023 17:30
@achmelo achmelo merged commit cc45774 into v2.x.x Apr 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the reboot/fixParsingSwagger2 branch April 20, 2023 19:31
@github-actions
Copy link

Version info from a repo admin is required to publish a new version. Please add one of the following labels within 30 minutes:

  • release-current: 2.8.5 (default)
  • release-patch: 2.8.6
  • release-minor: 2.9.0

Powered by Octorelease 🚀

@github-actions
Copy link

Release failed for the v2.x.x branch. 😢

HttpError: Server Error
    at /home/runner/work/_actions/zowe-actions/octorelease/master/dist/github.js:4858:25
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)```
Check the [workflow run](https://github.com/zowe/api-layer/actions/runs/4758162279) for more error details.

<sub>Powered by Octorelease :rocket:</sub>

pj892031 added a commit that referenced this pull request Apr 24, 2023
* fix

* fix in case an error is thrown (i.e. class is not defined)

* basic test to verify the API doc service is parsing the document

* extend unit test for object verification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants