fix(secrets): Add prebuildCheck.js script to check if prebuilds exist when building
#1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1788 +/- ##
=======================================
Coverage 92.82% 92.82%
=======================================
Files 423 423
Lines 7191 7191
Branches 1319 1319
=======================================
Hits 6675 6675
Misses 515 515
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <[email protected]>
traeok
changed the title
preinstall.js script to check if prebuilds exist when buildingprebuildCheck.js script to check if prebuilds exist when building
traeok
requested review from
t1m0thyj,
gejohnston,
zFernand0,
awharn,
KevinLoesch1,
ATorrise and
adam-wolfe
gejohnston
approved these changes
Aug 23, 2023
awharn
approved these changes
Aug 23, 2023
t1m0thyj
reviewed
Aug 24, 2023
adam-wolfe
approved these changes
Aug 24, 2023
t1m0thyj
reviewed
Aug 24, 2023
| @@ -39,7 +40,7 @@ | |||
| "build": "npm run build:ts && cd src/keyring && napi build --config napi.json --js false --platform --release", | |||
| "build:debug": "cd src/keyring && napi build --config napi.json --js false --platform", | |||
| "build:ts": "tsc --pretty", | |||
| "install": "node src/keyring/index.js || npm run rebuild", | |||
| "install": "node scripts/prebuildCheck.js || npm run rebuild", | |||
| "prepack": "node ../../scripts/prepareLicenses.js", | |||
| "prepublishOnly": "bash scripts/prebuildify.sh", | |||
| "rebuild": "npx --yes --package=@napi-rs/[email protected] -- napi build --config src/keyring/napi.json --cargo-cwd src/keyring --platform --release --js=false src/keyring", | |||
There was a problem hiding this comment.
The "rebuild" script seems to fail with newer versions of npm: sh: 1: napi: not found
This may be caused by an npm bug so not sure if we can do anything to fix it: npm/cli#6435
Signed-off-by: Trae Yelovich <[email protected]>
t1m0thyj
approved these changes
Aug 25, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
This PR adds a
preinstall.jsscript to the Secrets SDK install process so that it will only fail if the prebuilds are not found during installation, triggering a rebuild.Fixes #1787 - if the user's architecture/platform is not supported, Cargo is still required to build the Secrets SDK.
How to Test
First run the
prepublishOnlyscript for the Secrets SDK so that it downloads the prebuilds locally. Then, try installing Zowe CLI with this branch in a Linux environment withoutlibsecretinstalled. The CLI should still install without throwing any errors with the Secret SDK during installation.Review Checklist
I certify that I have: