Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building ZE with Node 18 #1989

Merged
merged 5 commits into from
Oct 27, 2022
Merged

Support building ZE with Node 18 #1989

merged 5 commits into from
Oct 27, 2022

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Oct 27, 2022

Proposed changes

Support building ZE with Node 18 - resolves #1987

Release Notes

Milestone: 2.4

Changelog: N/A

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

The "hack" to make webpack 4 work with Node 18 came from here: brave/brave-core

The "source-map" dev dep also needed an update to support Node 18: mozilla/source-map#432

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 74.50% // Head: 74.50% // No change to project coverage 👍

Coverage data is based on head (922d123) compared to base (438fb20).
Patch has no changes to coverable lines.

❗ Current head 922d123 differs from pull request most recent head d73fb13. Consider uploading reports for the commit d73fb13 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1989   +/-   ##
=======================================
  Coverage   74.50%   74.50%           
=======================================
  Files          63       63           
  Lines        7080     7080           
  Branches     1534     1534           
=======================================
  Hits         5275     5275           
  Misses       1798     1798           
  Partials        7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@t1m0thyj t1m0thyj added the no-changelog Add to PR's that don't require a CHANGELOG update label Oct 27, 2022
Signed-off-by: Timothy Johnson <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
94.1% 94.1% Duplication

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM! 😋

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @t1m0thyj

@JillieBeanSim JillieBeanSim merged commit 6ce8b74 into main Oct 27, 2022
@JillieBeanSim JillieBeanSim deleted the support-node18 branch October 27, 2022 13:29
@JillieBeanSim JillieBeanSim added this to the 2.4.1 milestone Nov 17, 2022
zFernand0 added a commit that referenced this pull request May 16, 2023
zFernand0 added a commit that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support building ZE with Node 18
3 participants