update relevant gems to support up to Oauth2 v2.0.4 #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
👋 This PR would really help me out in an upgrade I am working on right now. Anything I can do to help move it forward? |
zquestz
reviewed
Sep 3, 2022
| @@ -9,8 +9,8 @@ Gem::Specification.new do |gem| | |||
| gem.name = 'omniauth-google-oauth2' | |||
| gem.version = OmniAuth::GoogleOauth2::VERSION | |||
| gem.license = 'MIT' | |||
| gem.summary = %(A Google OAuth2 strategy for OmniAuth 1.x) | |||
| gem.description = %(A Google OAuth2 strategy for OmniAuth 1.x. This allows you to login to Google with your ruby app.) | |||
| gem.summary = %(A Google OAuth2 strategy for OmniAuth 2.x) | |||
There was a problem hiding this comment.
This doesn't look accurate. OmniAuth is not 2.x...
|
No longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing quick fix for #426 & #425
Updating did not require newer ruby versions. had all tests pass on ruby 2.3.8.