Skip to content

Commit

Permalink
fix issue with default args in connection id makers (#491)
Browse files Browse the repository at this point in the history
  • Loading branch information
zth authored Feb 26, 2024
1 parent b58da6e commit d7e0d32
Show file tree
Hide file tree
Showing 7 changed files with 28 additions and 20 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

# **Version 3**

- Set explicit peer dependencies: `@rescript/react >= 0.12.1`, `[email protected]`, `[email protected]`.
- Clean up connection handler generators now that v3 let us use a better representation.
- Fix issue with default args in connection id makers. https://github.com/zth/rescript-relay/pull/488

# 3.0.0-rc.4

- Fix an error in postinstall.js when reinstalling rescript-relay dependency (https://github.com/zth/rescript-relay/pull/487)
Expand Down
2 changes: 1 addition & 1 deletion packages/relay
2 changes: 1 addition & 1 deletion packages/rescript-relay/__tests__/Test_connections.res
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module Fragment = %relay(`
test: { type: "Boolean", defaultValue: true }
orderBy: {
type: "[UserOrder!]"
defaultValue: { direction: ASC, field: FIRST_NAME }
defaultValue: [{ direction: ASC, field: FIRST_NAME }]
}
) {
__id
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions packages/rescript-relay/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
},
"devDependencies": {
"@glennsl/rescript-fetch": "^0.2.0",
"@rescript/react": "0.12.0",
"@rescript/react": "0.12.1",
"@testing-library/jest-dom": "^5.16.3",
"@testing-library/react": "^13.0.0-alpha.6",
"graphql-query-test-mock": "^0.12.1",
Expand All @@ -54,8 +54,8 @@
"rescript": "^11.0.0"
},
"peerDependencies": {
"@rescript/react": "^0.12.0",
"react-relay": ">=16.0.0",
"@rescript/react": "^0.12.1",
"react-relay": "16.0.0",
"relay-runtime": "*",
"rescript": "^11.0.0"
},
Expand Down
8 changes: 4 additions & 4 deletions packages/rescript-relay/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -521,10 +521,10 @@
"@jridgewell/resolve-uri" "^3.0.3"
"@jridgewell/sourcemap-codec" "^1.4.10"

"@rescript/[email protected].0":
version "0.12.0"
resolved "https://registry.yarnpkg.com/@rescript/react/-/react-0.12.0.tgz#d72f0561ec9c4ae04c5db0a752087190ba7d3f40"
integrity sha512-EBLsf5rD7sJOjgfLLGwuLw/hONszc3UtYnIVgv7OdTyUNR41/m4deVm62PI0agvr3kWakXz4KchKRSd+19/bRA==
"@rescript/[email protected].1":
version "0.12.1"
resolved "https://registry.yarnpkg.com/@rescript/react/-/react-0.12.1.tgz#7bddb957a1bc08b944c6597f28549ac410982d64"
integrity sha512-ZD7nhDr5FZgLYqRH9s4CNM+LRz/3IMuTb+LH12fd2Akk0xYkYUP+DZveB2VQUC2UohJnTf/c8yPSNsiFihVCCg==

"@sinonjs/commons@^1.7.0":
version "1.8.3"
Expand Down

0 comments on commit d7e0d32

Please sign in to comment.