Use ReScript 10 #397
Merged
Use ReScript 10 #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Just wondering, does this mean 10+ is required? If so, can we make it so that 9 is also allowed? |
|
I think we could use ">=9". But in case you start to use v10 feature, it won't work and you might not be aware of it. |
|
I think allowing 9 now as well to start would be ideal. I have a few features in the pipe that will require v10, and at that point I can bump the minimum to v10. Would that be ok for you and your use case too? |
MoOx
force-pushed
the
patch-3
branch
2 times, most recently
from
bf72189
to
4b040b7
Compare
|
Should be ok, I used 10 for devDep, but peerDep to >=9.1.2 |
|
Thank you @MoOx ! Would you also add an entry to the changelog? |
|
@zth done ! |
|
🙏 thank you @MoOx ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #396