Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remove-unused-fields in CI #409

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Fix remove-unused-fields in CI #409

merged 2 commits into from
Nov 24, 2022

Conversation

DZakh
Copy link
Contributor

@DZakh DZakh commented Nov 24, 2022

I've started working on updating the node version in CI from 14 to 16.
But the lint script started failing because of rescript-relay-cli remove-unused-fields --ci --verbose exiting with code 1.
Here's the error with debug on:
image

After looking at the source code, several hours of different tries, and multiple wild guesses, I've found the solution. It worked fine before because the npx with node@14 doesn't have the prompt.

For some reason, I couldn't reproduce the error locally and only in CI, but I've tested the fix using https://pnpm.io/cli/patch, and it solved the problem.

@zth
Copy link
Owner

zth commented Nov 24, 2022

Haha, sorry you had to go through that! 😬😃 Thanks for the fix! Would you also add it to the changelog?

@DZakh
Copy link
Contributor Author

DZakh commented Nov 24, 2022

Done

@zth zth merged commit 4362511 into zth:master Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants