Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs reflecting v3 changes #509

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

reck753
Copy link
Contributor

@reck753 reck753 commented May 31, 2024

Ready to merge when v3 release is published (not rc).

Here is what changed:

  • updated getting started with new required package versions
  • include how to setup rescript.json on Windows in getting started
  • remove trailing units
  • stop using Belt module in examples and assume RescriptCore is globally open
  • use non-deprecated React hooks in examples (useCallback5 -> useCallback)
  • stop using makeVariables in examples and remove it from docs

- update getting started
- include how to setup rescript.json on Windows in getting started
- remove trailing units
- stop using Belt module in examples and assume RescriptCore is globally open
- use non-deprecated React hooks in examples (`useCallback5` -> `useCallback`)
- stop using `makeVariables` in examples and remove it from docs
Copy link
Owner

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Just a few smaller changes that are really nits.

Co-authored-by: Gabriel Nordeborn <[email protected]>
@zth
Copy link
Owner

zth commented Jun 5, 2024

Fantastic, thanks! Merging and releasing 3.0.0 soon.

@zth zth merged commit 11ad27a into zth:master Jul 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants