Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply emoji-display nuances to message content, same as reactions #966

Open
gnprice opened this issue Sep 27, 2024 · 0 comments
Open

Apply emoji-display nuances to message content, same as reactions #966

gnprice opened this issue Sep 27, 2024 · 0 comments
Labels
a-a11y Accessibility a-content Parsing and rendering Zulip HTML content, notably message contents
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Sep 27, 2024

When emoji appear as emoji reactions on messages, there are a couple of nuances to how we decide exactly what to show:

  • For image emoji we pick a still image instead of an animated one, where applicable, depending on a setting.
  • For image emoji we pass RealmContentNetworkImage.errorBuilder so that if the image doesn't load, we show the emoji's name as text.
  • For both Unicode and image emoji we check if the user has set Emojiset.text, and if so then we show the emoji's name as text instead of the glyph or image.

For details of these, see lib/widgets/emoji_reaction.dart.

When emoji appear in message content, however, we don't currently do any of the above.

I believe this discrepancy is only because the rendering of emoji in message content dates to the early prototype, when I was skipping over gnarly details of Zulip that didn't seem relevant to evaluating Flutter, while the rendering of emoji reactions was built (by @chrisbobbe) at a somewhat later stage. So we should add those same nuances to emoji in message content.

Filing this as a post-launch issue, though, because I don't think zulip-mobile handles any of these nuances. Also these are all fairly unusual situations and I don't think we've heard any users mention them — I noticed the discrepancy only through working on the code, for #669.

@gnprice gnprice added a-content Parsing and rendering Zulip HTML content, notably message contents a-a11y Accessibility labels Sep 27, 2024
@gnprice gnprice added this to the Post-launch milestone Sep 27, 2024
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Sep 27, 2024
This will apply in other places we show an emoji, too,
such as the emoji picker.

What, you might ask, about the other place we already show emoji,
namely in message content?  We should probably apply this logic
there too, but we'll leave that for later.  Tracking it as issue zulip#966.
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Sep 30, 2024
This will apply in other places we show an emoji, too,
such as the emoji picker.

What, you might ask, about the other place we already show emoji,
namely in message content?  We should probably apply this logic
there too, but we'll leave that for later.  Tracking it as issue zulip#966.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-a11y Accessibility a-content Parsing and rendering Zulip HTML content, notably message contents
Projects
Status: No status
Development

No branches or pull requests

1 participant