Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin flutter SDK version via git submodule #579

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Commits on Apr 30, 2024

  1. check: pin flutter version

    * Introduce a git submodule to pin the version of flutter SDK under
      `vendor/flutter`.
    * Use direnv to add `vendor/flutter/bin` to the current PATH so that
      subsequent calls to `flutter` on the shell uses the our pinned
      version of flutter.
    * Update instructions to use pinned version of flutter.
    * Pin to 18340ea16c of flutter which matches the current lowerbound
    version in pubsec.yaml (3.21.0-12.0.pre.26).
    
    NOTE: Users can still choose to opt-out and use their own version of
    flutter. This just provides a recommended and tested version on our
    CI.
    
    Closes zulip#15
    chrisirhc authored and gnprice committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    81363a8 View commit details
    Browse the repository at this point in the history
  2. check: add flutter-main check

    The `check-flutter-main` job serves 2 purposes:
    1. It checks that the code works with the flutter's latest main
       channel.
    2. It checks that our code environment setup works with a typical
       Flutter SDK installation setup (via ~/flutter).
    chrisirhc authored and gnprice committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b990e53 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Update README.md

    Co-authored-by: Greg Price <[email protected]>
    chrisirhc and gnprice authored May 5, 2024
    Configuration menu
    Copy the full SHA
    03e305d View commit details
    Browse the repository at this point in the history
  2. Update README.md

    Co-authored-by: Greg Price <[email protected]>
    chrisirhc and gnprice authored May 5, 2024
    Configuration menu
    Copy the full SHA
    093f5e5 View commit details
    Browse the repository at this point in the history
  3. Update tools/setup-vendor-flutter

    Co-authored-by: Greg Price <[email protected]>
    chrisirhc and gnprice authored May 5, 2024
    Configuration menu
    Copy the full SHA
    44f5d2f View commit details
    Browse the repository at this point in the history
  4. Update README.md

    Co-authored-by: Greg Price <[email protected]>
    chrisirhc and gnprice authored May 5, 2024
    Configuration menu
    Copy the full SHA
    7a97c02 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6004882 View commit details
    Browse the repository at this point in the history
  6. fix git.sh comment

    chrisirhc committed May 5, 2024
    Configuration menu
    Copy the full SHA
    e444099 View commit details
    Browse the repository at this point in the history