-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin flutter SDK version via git submodule #579
Open
chrisirhc
wants to merge
8
commits into
zulip:main
Choose a base branch
from
chrisirhc:chua/pin-via-submodule
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Apr 30, 2024
-
* Introduce a git submodule to pin the version of flutter SDK under `vendor/flutter`. * Use direnv to add `vendor/flutter/bin` to the current PATH so that subsequent calls to `flutter` on the shell uses the our pinned version of flutter. * Update instructions to use pinned version of flutter. * Pin to 18340ea16c of flutter which matches the current lowerbound version in pubsec.yaml (3.21.0-12.0.pre.26). NOTE: Users can still choose to opt-out and use their own version of flutter. This just provides a recommended and tested version on our CI. Closes zulip#15
Configuration menu - View commit details
-
Copy full SHA for 81363a8 - Browse repository at this point
Copy the full SHA 81363a8View commit details -
The `check-flutter-main` job serves 2 purposes: 1. It checks that the code works with the flutter's latest main channel. 2. It checks that our code environment setup works with a typical Flutter SDK installation setup (via ~/flutter).
Configuration menu - View commit details
-
Copy full SHA for b990e53 - Browse repository at this point
Copy the full SHA b990e53View commit details
Commits on May 5, 2024
-
Co-authored-by: Greg Price <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 03e305d - Browse repository at this point
Copy the full SHA 03e305dView commit details -
Co-authored-by: Greg Price <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 093f5e5 - Browse repository at this point
Copy the full SHA 093f5e5View commit details -
Update tools/setup-vendor-flutter
Co-authored-by: Greg Price <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 44f5d2f - Browse repository at this point
Copy the full SHA 44f5d2fView commit details -
Co-authored-by: Greg Price <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7a97c02 - Browse repository at this point
Copy the full SHA 7a97c02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6004882 - Browse repository at this point
Copy the full SHA 6004882View commit details -
Configuration menu - View commit details
-
Copy full SHA for e444099 - Browse repository at this point
Copy the full SHA e444099View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.