Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry failed message sends #3120

Closed
borisyankov opened this issue Nov 8, 2018 · 0 comments
Closed

Retry failed message sends #3120

borisyankov opened this issue Nov 8, 2018 · 0 comments
Assignees
@borisyankov

Comments

@borisyankov
Copy link
Contributor

In trySendMessages we do send outbox messages.
If we fail to send them we are not retrying.

We are 'randomly' retrying by dispatching dispatch(trySendMessages()); in few places:

  • when a new message is sent
  • on initial message fetch
  • on connectivity state change

We should probably replace all these with a loop that periodically retries, regardless of these specific conditions.
@borisyankov borisyankov self-assigned this Nov 8, 2018
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jan 14, 2019
@borisyankov
Retry if message send fails
5c88a15 
Fixes zulip#3120

...
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jan 14, 2019
@borisyankov
Retry if message send fails
4850c61 
Fixes zulip#3120

...
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jan 14, 2019
@borisyankov
Retry if message sending fails
17e27ce 
Fixes zulip#3120

Try sending messages and keep retrying if sending fails.
Using `progressiveTimeout` we make sure we are not trying too often.

Thanks to `state.session.outboxSending` we are sure there will be
no two loops at the same time.
@borisyankov borisyankov mentioned this issue Jan 14, 2019
Merged
gnprice pushed a commit to borisyankov/zulip-mobile that referenced this issue Jan 14, 2019
@borisyankov @gnprice
outbox: Retry if message sending fails.
f00dce5 
Fixes zulip#3120.

Try sending messages and keep retrying if sending fails.
Using `progressiveTimeout` we make sure we are not trying too often.

Thanks to `state.session.outboxSending` we are sure there will be
no two loops at the same time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@borisyankov borisyankov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@borisyankov