Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Zulipbot messages #216

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Improve Zulipbot messages #216

wants to merge 5 commits into from

Commits on Apr 18, 2022

  1. templates: Improve warnings for abandoned issues. 

    The new language aims to be brief while still providing some motivation for
what's happening.
    @alya
    alya committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    bc738e6 View commit details
    Browse the repository at this point in the history

  2. templates: Improve review management comments. 

    - The new language is more brief.
- There is an option for the contributor to say that they won't
  be updating their PR.
    @alya
    alya committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    235b118 View commit details
    Browse the repository at this point in the history

  3. templates: Improve fixCommitWarning. 

    - Adds an explanation of why linking the PR to the issue is helpful.
- Links to the commit message documentation.
    @alya
    alya committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    d2ed1f4 View commit details
    Browse the repository at this point in the history

  4. templates: Improve multipleClaimWarning. 

    - Shortens the text.
- Adds a link to the contributor guide.
    @alya
    alya committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    37eb20d View commit details
    Browse the repository at this point in the history

  5. templates: Add list of steps to new contributor message. 

    The goal here is to encourage folks not to claim an issue until they
are ready.

We will need to make sure that they don't get assigned the issue if someone
else claims it in the meantime.

We're counting on the contributor not to accept the GitHub invite until
ready, which is not ideal because (a) they might just accept it, and
(b) there's a risk that the invite will expire. So we'd probably be better
off splitting this into two interactions (joining repo; claiming issue).

This also shortens the message if the initial invite hasn't been accepted.
    @alya
    alya committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    403ec2f View commit details
    Browse the repository at this point in the history