feat: add method to return Zniffer capture as Buffer #6836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
previously approved these changes
May 15, 2024
AlCalzone
approved these changes
May 15, 2024
|
@zwave-js-bot automerge |
zwave-js-bot
approved these changes
May 15, 2024
AlCalzone
added a commit
that referenced
this pull request
May 21, 2024
This release contains several bugfixes and improvements for Zniffer, as well as fixing some deviations from the Z-Wave specification. ### Features * Zniffer: Expose raw capture data in emitted frames (#6852) * Zniffer: Expose previously captured frames using `capturedFrames` property and `clearCapturedFrames()` method (#6852) * Zniffer: Add method to return saved capture file as Buffer (#6836) * Zniffer: Add a special frame type to distinguish Broadcast frames from singlecast frames without having to inspect the node ID (#6863) * Zniffer: Add an optional parameter for `znifferProtocolDataRateToString` to omit the protocol name (#6863) * Zniffer: Add an option to limit the number of captured frames kept in memory (#6863) ### Bugfixes * Always query Basic CC version as part of the interview * Do not report `Z-Wave Protocol CC` and `Z-Wave Long Range CC` as supported * Encode CCs using the version implemented by Z-Wave JS, not the target's version * Abort S2 bootstrapping when first `KEXReport` incorrectly has echo flag set * Correct NIF contents, distinguish between securely and insecurely supported commands * Respond to `ManufacturerSpecificCCGet` * Correct parsing of auto-channel capabilities in `GetLongRangeChannelResponse` (#6850) * Include LR node information in NVM conversion (#6846) * Zniffer: Expose `rssi` field in all `Frame` types (#6851) * Zniffer: Expose payload in ExplorerInclusionRequest frame ### Changes under the hood * Docs: add link to Zooz 800 series firmware upgrade (#6856, #6862)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to support Zniffer's in the server, we need the
Bufferfor the capture instead of outputting to a file. This enables that to occur