Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respond to more queries from other devices, handle supervised queries correctly, harden S2 extension parsing and validation #6866

Merged
merged 18 commits into from
May 29, 2024

Conversation

AlCalzone
Copy link
Member

@AlCalzone AlCalzone commented May 21, 2024

This PR fixes a lot of small deviations from the specifications and the handling of edge cases the CTT uses to test implementations. Also adds a lot of mandatory responses to queries that weren't handled before.

fixes: #6865
fixes: #6864

@AlCalzone AlCalzone changed the title fix: respond to more queries from other devices, handle supervised queries correctly fix: respond to more queries from other devices, handle supervised queries correctly, harden S2 extension parsing May 24, 2024
@AlCalzone AlCalzone added the Spec compliance 👮🏻‍♂️ Needs to be done to comply with the specifications label May 24, 2024
@AlCalzone AlCalzone changed the title fix: respond to more queries from other devices, handle supervised queries correctly, harden S2 extension parsing fix: respond to more queries from other devices, handle supervised queries correctly, harden S2 extension parsing and validation May 29, 2024
test/debug.js Dismissed Show dismissed Hide dismissed
test/debug.js Dismissed Show dismissed Hide dismissed
test/debug.js Dismissed Show dismissed Hide dismissed
test/debug.js Dismissed Show dismissed Hide dismissed
@AlCalzone
Copy link
Member Author

@zwave-js-bot automerge

@zwave-js-bot zwave-js-bot merged commit 73c5482 into master May 29, 2024
17 checks passed
@zwave-js-bot zwave-js-bot deleted the cert-fixes-hello branch May 29, 2024 10:20
AlCalzone added a commit that referenced this pull request Jun 5, 2024
### Features
* Support `SendTestFrame` command and perform powerlevel tests on behalf of other nodes (#6889)

### Bugfixes
* Respond to more queries from other devices (#6866)
* Handle supervised queries from other devices correctly (#6866)
* Harden S2 extension parsing and validation (#6866)
* Fixed some more edge cases found by S2 certification tests (#6887)
* Abort S2 bootstrapping when CSA is requested (not supported in Z-Wave JS) (#6890)

### Config file changes
* Parameter update for Zooz Zen16 v2.0 and v2.10 (#6855)
* Override Central Scene CC version for Springs Window Fashions BRZ (#6870)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spec compliance 👮🏻‍♂️ Needs to be done to comply with the specifications
Projects
None yet
2 participants