fix: race condition causing successful OTW update to be considered timed out #6912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
changed the title
|
@zwave-js-bot automerge |
zwave-js-bot
approved these changes
Jun 10, 2024
AlCalzone
added a commit
that referenced
this pull request
Jun 10, 2024
### Features * Add `ZWaveNode.createDump()` method to save debug information in a format Z-Wave JS understands (#6906) * Support node dumps created by `ZWaveNode.createDump()` as input for `mock-server' (#6907) * `mock-server`: enable mDNS discovery (#6909) * Add driver option to configure vendor-specific constants Z-Wave JS uses to reply to requests from other nodes, including manufacturer ID, product type/ID and hardware version (#6876) ### Bugfixes * Fixed a race condition that would cause a timeout error to be shown after an actually successful OTW update (#6912) * Create `supportedNotificationTypes` and `supportedNotificationEvents` values with `alarmMapping` compat flag (#6914) ### Config file changes * Correct config parameters for Minoston MP21ZD Dimmer Plug (#6686)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that newer bootloaders (or the better hardware, who knows) can cause the menu screen to be sent too quickly after an successful OTW update, causing Z-Wave JS to miss it due to sequential waiting.
With this change, we wait for both the "serial upload complete" message and the bootloader menu at the same time.
This means that successful OTW updates on a Zooz 800 series stick no longer end with
Error_Timeout.Fixes: #5356