Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multicast groups for LR nodes #7042

Merged
merged 2 commits into from
Jul 25, 2024
Merged

fix: multicast groups for LR nodes #7042

merged 2 commits into from
Jul 25, 2024

Conversation

alexschneider
Copy link
Contributor

Fixes #7035

AlCalzone
AlCalzone requested changes Jul 25, 2024
View reviewed changes
Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work for 2 reasons:

  1. Changing encodeNodeBitmask breaks code that expects the bitmask to be 29 bytes long
  2. Using 1000-character strings as keys does not sound like a good idea

I'll make some modifications.

@AlCalzone AlCalzone mentioned this pull request Jul 25, 2024
Closed
@AlCalzone AlCalzone merged commit 44c4ad0 into zwave-js:master Jul 25, 2024
17 checks passed
@alexschneider alexschneider deleted the fix-multicast-groups branch July 25, 2024 11:35
AlCalzone added a commit that referenced this pull request Jul 30, 2024
@AlCalzone
chore: release v13.0.3
a8ce3e3 
### Bugfixes
* Fixed an issue causing all ZWLR multicast groups to be considered identical (#7042)
* Fixed a startup crash on Zniffers older than FW 2.55 (#7051)

### Changes under the hood
* Fixed the devcontainer setup (#7041)
* Look at all test files to resolve dirty tests (#7045)
* Introduce `yarn bootstrap` command to set up environment (#7046)
* Add mocks for Binary and Color Switch CC (#7056)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCalzone AlCalzone AlCalzone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZWLR Multicast Command Affects More Nodes Than Targeted
2 participants
@alexschneider @AlCalzone