feat(config): add Philio Technology Smart Keypad #7168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MartinHjelmare
commented
Sep 15, 2024
MartinHjelmare
commented
- Add config file for Philio Technology Smart Keypad (psk01).
- Add two templates that could be used frequently for devices from this manufacturer.
MartinHjelmare
commented
Sep 16, 2024
AlCalzone
requested changes
Sep 16, 2024
Comment on lines
56
to
58
| "$import": "templates/philio_template.json#auto_report_tick", | ||
| "label": "Auto Report Time Unit", | ||
| "description": "Define the time scale for automatic report. This setting will affect configuration no. 6." |
There was a problem hiding this comment.
I don't understand this parameter. Is it a multiplier for the interval set in parameter 6?
There was a problem hiding this comment.
Yes, exactly.
There was a problem hiding this comment.
Suggested change
| "$import": "templates/philio_template.json#auto_report_tick", | |
| "label": "Auto Report Time Unit", | |
| "description": "Define the time scale for automatic report. This setting will affect configuration no. 6." | |
| "$import": "templates/philio_template.json#auto_report_tick", | |
| "label": "Auto Report Time Unit", | |
| "description": "Define the time scale for automatic reports. This value will be multiplied with configuration no. 6. to set the time interval between reports." |
AlCalzone
approved these changes
Sep 17, 2024
MartinHjelmare
commented
Sep 17, 2024
AlCalzone
added a commit
that referenced
this pull request
Sep 17, 2024
### Bugfixes * Fixed the identification of the primary controller role on some older controllers (#7174) * Fixed an issue where passing a custom log transport to `updateOptions` would cause a call stack overflow (#7173) * Implement deserialization for more `WindowCoveringCC` commands to be used in mocks (#7159) ### Config file changes * Add Philio Technology Smart Keypad (#7168, #7175) * Add LED indication parameter for Inovelli NZW31 dimmer (#7172) ### Changes under the hood * Fixed a build issue on Windows systems * Make `mock-server.js` executable (#7160, #7161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.