Add syntax highlight code for log files #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeKar
reviewed
Mar 12, 2024
taconi
force-pushed
the
syntax-highlighting/log
branch
from
67b3b15
to
60dd341
Compare
JoeKar
reviewed
Mar 13, 2024
taconi
force-pushed
the
syntax-highlighting/log
branch
from
60dd341
to
bd88878
Compare
JoeKar
reviewed
Apr 15, 2024
| - identifier: "^(\\d{4}[-/]?\\d{2}[-/]?\\d{2}\\s\\d{2}:\\d{2}(:\\d{2})?(\\.?\\d{2,8})?)" | ||
| - identifier: "^([0-2][0-9]|[0-2]-?[0-9][0-9]-?[0-9][0-9])\\-([0-1][0-9])\\-([0-3][0-9]) ([0-2][0-9])\\:([0-5][0-9])\\:([0-5][0-9]),([0-9][0-9][0-9])" | ||
| # ISO 8601:2004(E) | ||
| - identifier: "" |
There was a problem hiding this comment.
With #3253 this line came up after greping over the current syntax definitions.
From my current perspective this isn't needed or do I miss something right now?
There was a problem hiding this comment.
It must have been some test I forgot to take, it wasn't supposed to be like this.
There was a problem hiding this comment.
Ok, then we solve this with #3256, to which you already respond.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding log file support by default so you don't need to install the language-log plugin.