Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display ingested file paths instead of file names #1825

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

omartrigui
Copy link

Description

The current implementation only displays the ingested filenames, which can be confusing for users when the specified directory for ingestion contains nested directories with multiple levels. Additionally, the existing implementation discards files with different names e.g. a root_path directory contains index.md, dir1/index.md, dir2/index.md, only one single index.md file is displayed. This PR enhances the display by including the file paths instead of just filenames, addressing the potential confusion caused by nested directories, and ensures that all files are appropriately displayed without discarding any.

Fix preview

Screenshot from 2024-04-03 10-10-22

@omartrigui omartrigui changed the title Show ingested file paths instead of file names Display ingested file paths instead of file names Apr 3, 2024
@icsy7867
Copy link
Contributor

Personally this would break my use case for PGPT for me. Almost all of my items are web URLS. So the "filename" is actually the URL of a confluence page, web article, policy, etc...

This PR would not work with how I use PGPT. Not sure how others feel, but I think this should be a toggleable (Off by default) setting.

IMO.

@AnonTester
Copy link

+1 for an option
While my use case will benefit from this PR, the current behaviour should remain default to avoid breaking setups or resulting in unexpected results, but an option to switch to path display and allowing files with the same filename in different folders would be great!
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants