feat: [asset-swapper] Add Crypto.com as a source #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimpers
approved these changes
Nov 23, 2020
Comment on lines
202
to
204
| case ERC20BridgeSource.CryptoCom: | ||
| // HACK: deploy using unique address | ||
| return opts.contractAddresses.sushiswapBridge; |
There was a problem hiding this comment.
Is the only side effect of this that it would show up as sushi volume in analytics?
There was a problem hiding this comment.
Yeah and avoid paying the overhead of FQT<-->Bridge transfer costs
dekz
force-pushed
the
feat/asset-swapper/crypto-com
branch
2 times, most recently
from
6a296bd
to
2c924bb
Compare
dekz
requested review from
abandeali1,
dorothy-zbornak,
hysz and
moodlezoup
as code owners
dekz
force-pushed
the
feat/asset-swapper/crypto-com
branch
2 times, most recently
from
9d134c9
to
4dbf7da
Compare
dorothy-zbornak
approved these changes
Nov 30, 2020
| @@ -332,6 +332,7 @@ export async function runMigrationsAsync( | |||
| dodoBridge: NULL_ADDRESS, | |||
| dodoHelper: NULL_ADDRESS, | |||
| snowSwapBridge: NULL_ADDRESS, | |||
| cryptoComBridge: NULL_ADDRESS, | |||
There was a problem hiding this comment.
I thought we don't have bridges in this interface anymore?
There was a problem hiding this comment.
What do you mean, we need it to branch off in the BridgeAdapter.
We took them out of contract-addresses and moved them into AS.
dekz
force-pushed
the
feat/asset-swapper/crypto-com
branch
from
85681df
to
6a96c93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Crypto.com as a source, a fork of Uniswap V2.
Sims
TODO:
eligible for VIPTesting instructions
Types of changes
Checklist:
[WIP]if necessary.