Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows linking an external/system copy of
liblz4
(particularly, a system-wide shared library as preferred or required for Linux distribution packaging), in the same manner asbzip2-sys
, by imitating:As noted in alexcrichton/bzip2-rs#58 (comment), some would consider changing the default linking of
liblz4
a breaking change.This PR is offered with the purpose of packaging the
lz4-sys
andlz4
crates in Fedora Linux, where bundling is discouraged, but allowed under certain circumstances.This PR would fix #36.
Based on feedback in the Fedora Linux package review, I dropped the part of this PR that would have added a
static
feature akin to alexcrichton/bzip2-rs#78, but I did so by reverting it rather than force-pushing, so you can still see how it would have worked if you are interested.