[bzip2-sys] use the system bzip2 if found via pkg-config #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Alexandre Salim <[email protected]>
|
Looks like rustfmt is failing? Otherwise seems reasonable! |
|
Ah, let me fix that, thanks for flagging! |
Signed-off-by: Michel Alexandre Salim <[email protected]>
|
tested by building the upcoming Fedora RPM that includes this patch in Mock, with the bundled bzip2 stripped; it builds fine if the development headers for bzip2 are found via pkgconfig https://salimma.fedorapeople.org/specs/rust/rust-bzip2-sys-0.1.8+1.0.8-1.fc32.src.rpm |
|
This is clearly a breaking changes for dependents that expect to link bzip2 statically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar approach to libz-sys: https://github.com/rust-lang/libz-sys/blob/master/build.rs
Signed-off-by: Michel Alexandre Salim [email protected]
This change is