-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy RC 398 to Production #10959
Merged
Merged
Deploy RC 398 to Production #10959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#10943) We have observed a number of issues with the `GpoConfirmationUploader`. We are adding more visibility to the job to improve our monitoring and alerting to deal with failures that come up. This commit adds a line to `events.log` when confirmations get uploaded. It includes a count of the confirmations that were uploaded so we can build a metric for that. This new logging is in addition to the records that get written to the `letter_requests_to_usps_ftp_logs` which are used in monthly reports. [skip changelog]
…not availble (#10945) This commit fixes a bug where the `RequestLetterController` was not respecting `GpoVerifyByMailPolicy#send_letter_available?`. If that method returned false then links would be hidden but users could still visit the controller directly and request letters. This commit adds a before action to fix the issue and adds tests. [skip changelog]
changelog: Internal, Automated Testing, Add spec to ensure mailers don't include SVG
* Split utilities stylesheet to standalone file changelog: Internal, Performance, Split utilities stylesheet to standalone file * Fix typos on utilities stylesheet Co-authored-by: Mitchell Henke <[email protected]> --------- Co-authored-by: Mitchell Henke <[email protected]>
changelog: Bug Fixes, OpenID Connect, Fix language selection on OpenID Connect logout page
* Bump rexml to resolve security advisory changelog: Internal, Dependencies, Update dependencies to resolve security advisories * Add rexml as explicit dependency Since we use it in our code, it should be an explicit dependency See: https://github.com/18F/identity-idp/blob/ea8a6081961d6c373a870dd5fea31efce89fde7e/app/services/proofing/aamva/request/verification_request.rb#L60-L102 * Sync AAMVA fixture to expected output Likely a result of ruby/rexml#164
* Remove 2023 SAML certificates changelog: Internal, Maintenance, Remove 2023 SAML certificates * remove 2023 files
* Align PIV/CAC setup-after-sign-in specs to user behavior changelog: Internal, Automated Testing, Align PIV/CAC setup-after-sign-in specs to user behavior * Remove unused code for PIV/CAC token processing
changelog: Internal, Analytics, Log new_device with email and password authentication event
changelog: Internal, Localization, Normalize newlines in locale data
changelog: Internal, Automated Testing, Use improved PKI service test stub consistently
mitchellhenke
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes
Internal