Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SubscribeStar.com #8215

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

WesVanVugt
Copy link
Contributor

No description provided.

@hkamran80 hkamran80 added the add site Issue/PR adds a site to the repo. label Oct 8, 2024
@@ -0,0 +1,14 @@
{
"Patreon": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the name to SubscribeStar.com

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the name to SubscribeStar, since that seemed more in line with the other sites. If I should be including the root domain, let me know and I'll add it.

Copy link
Member

@Carlgo11 Carlgo11 Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking!
That would normally be the preferred option, however as the name on the website is "SubscribeStar.com", it's better to stick with their preferred brand name.

When it comes to branding and trademarks it's always better to just go with what the company does. Makes for less legal trouble 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have corrected the name now, and I'll try to follow this rule for future PRs as well.

{
"Patreon": {
"domain": "subscribestar.com",
"url": "https://www.subscribestar.com/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you go to https://<domain> and it redirects to the value of the url-element then the url-element isn't needed.
Since this is the case for this PR, please remove the url-element:

Suggested change
"url": "https://www.subscribestar.com/",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add site Issue/PR adds a site to the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants