-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SubscribeStar.com #8215
Open
WesVanVugt
wants to merge
5
commits into
2factorauth:master
Choose a base branch
from
WesVanVugt:add_subscribestar
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+14
−0
Open
Add SubscribeStar.com #8215
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
27fb104
Implementation
wvanvugt-speedline 441e453
Remove additional domain
wvanvugt-speedline d31fd6d
Remove some unwanted properties
wvanvugt-speedline 9136d1d
Fix code review issues
wvanvugt-speedline a2cce87
Update site name
wvanvugt-speedline File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
@@ -0,0 +1,14 @@ | ||||
{ | ||||
"Patreon": { | ||||
"domain": "subscribestar.com", | ||||
"url": "https://www.subscribestar.com/", | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you go to
Suggested change
|
||||
"tfa": [ | ||||
"email", | ||||
"totp" | ||||
], | ||||
"documentation": "https://www.subscribestar.com/posts/1320999", | ||||
"categories": [ | ||||
"crowdfunding" | ||||
] | ||||
} | ||||
} |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the name to SubscribeStar.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the name to SubscribeStar, since that seemed more in line with the other sites. If I should be including the root domain, let me know and I'll add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thinking!
That would normally be the preferred option, however as the name on the website is "SubscribeStar.com", it's better to stick with their preferred brand name.
When it comes to branding and trademarks it's always better to just go with what the company does. Makes for less legal trouble 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have corrected the name now, and I'll try to follow this rule for future PRs as well.